search

StephenBlackWasAlreadyTaken / xDrip-Experimental

Experimental Branches for Collaboration on DexDrip
GNU General Public License v3.0
25 stars 62 forks source link

Xbridge and wifi working togeather. #346

Closed tzachi-dar closed 8 years ago

danpowell88 commented 8 years ago

All appears to be working correctly for me after a few days of testing.

tzachi-dar commented 8 years ago

Good to know, so if there are no more comments, I'll merge that to master soon.

tzachi-dar commented 8 years ago

Do you means something like this? public PointValueExtended(float x, float y) { super(x, y); }

AdrianLxM commented 8 years ago

Yes. Might at the moment be the exact same to call super instead of set (¿? - I didn't look at the constructor of the superclass) but would make it more robust to changes in the library in case they start doing something more in the constructor.

On 06/06/16 17:32, tzachi-dar wrote:

Do you means something like this? public PointValueExtended(float x, float y) { super(x, y); }

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/StephenBlackWasAlreadyTaken/xDrip-Experimental/pull/346#issuecomment-223995665, or mute the thread https://github.com/notifications/unsubscribe/AJPmwvtXmpCwbj88NxZA8ZLXRoa5_00Oks5qJD2hgaJpZM4IrDbU.

FREE 3D EARTH SCREENSAVER - Watch the Earth right on your desktop! Check it out at http://www.inbox.com/earth

tzachi-dar commented 8 years ago

Fixed in the DisableAlerts branch.

On Mon, Jun 6, 2016 at 6:50 PM, AdrianLxM notifications@github.com wrote:

Yes. Might at the moment be the exact same to call super instead of set (¿? - I didn't look at the constructor of the superclass) but would make it more robust to changes in the library in case they start doing something more in the constructor.

On 06/06/16 17:32, tzachi-dar wrote:

Do you means something like this? public PointValueExtended(float x, float y) { super(x, y); }

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/StephenBlackWasAlreadyTaken/xDrip-Experimental/pull/346#issuecomment-223995665>,

or mute the thread < https://github.com/notifications/unsubscribe/AJPmwvtXmpCwbj88NxZA8ZLXRoa5_00Oks5qJD2hgaJpZM4IrDbU .

FREE 3D EARTH SCREENSAVER - Watch the Earth right on your desktop! Check it out at http://www.inbox.com/earth

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/StephenBlackWasAlreadyTaken/xDrip-Experimental/pull/346#issuecomment-224001283, or mute the thread https://github.com/notifications/unsubscribe/AHkw5GZlKvoc7zTbe3UAaYcdEP2v3slyks5qJEHXgaJpZM4IrDbU .