search

StephenChong / google-breakpad

Automatically exported from code.google.com/p/google-breakpad
0 stars 0 forks source link

VC++ 2008 SP1 compile error exception_handler.cc(501) : error C2065: 'STATUS_INVALID_PARAMETER' : undeclared identifier #465

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. compile exception_handler with MS VC++ 2008 SP1 (Platform SDK 6.0A)
2.
3.

What is the expected output? What do you see instead?

Expect no build/compile error. But go the following compile error:
4>------ Build started: Project: exception_handler, Configuration: Debug Win32 
------
4>Compiling...
4>exception_handler.cc
4>c:\.work\touchfors_hg\libz\google-breakpad\src\client\windows\handler\exceptio
n_handler.cc(501) : error C2065: 'STATUS_INVALID_PARAMETER' : undeclared 
identifier

What version of the product are you using? On what operating system?

using revision 909 of google-breakpad from svn, Windows 7, MS VisualStudio 2008 
Pro SP1, Platform SDK 6.0A

Please provide any additional information below.

This bug was introduced by revision 897. Version of SDK (6.0A) included in 
VisualStudio 2008 doesn't define such constant. 
I think that compilation with MS Visual studio 2005 also broken. 
I'm attaching simple patch to workaround this issue. 
Installing newer SDK is not an option for me.

Original issue reported on code.google.com by pelek...@gmail.com on 31 Jan 2012 at 9:58

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by thestig@chromium.org on 29 Feb 2012 at 11:36

GoogleCodeExporter commented 9 years ago 
The patch looks fine to me, but I'm not able to land it, as I'm not a committer.

Original comment by si...@google.com on 1 Mar 2012 at 1:35

GoogleCodeExporter commented 9 years ago 
this patch also looks fine to me too,

Original comment by calflov...@gmail.com on 4 Jun 2012 at 3:42

GoogleCodeExporter commented 9 years ago 
Confirming that this is broken for VS 2005 as well.

Original comment by d...@s2games.com on 5 Apr 2013 at 7:35

GoogleCodeExporter commented 9 years ago 
pelekhay: Please upload the patch to https://breakpad.appspot.com/

Original comment by thestig@chromium.org on 5 Apr 2013 at 8:59

GoogleCodeExporter commented 9 years ago 
patch submitted for the review, Issue 555002

Original comment by pelek...@gmail.com on 10 Apr 2013 at 9:59