search

StephenChong / google-breakpad

Automatically exported from code.google.com/p/google-breakpad
0 stars 0 forks source link

Initializer list order does not match field declaration order in src/client/windows/crash_generation #658

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Reported by clang with -Wreorder:

../../breakpad/src/client/windows/crash_generation/crash_generation_client.cc(10
0,11) :  error: field 'thread_id_' will be initialized
after field 'server_process_id_' [-Werror,-Wreorder]
          thread_id_(0),
          ^
../../breakpad/src/client/windows/crash_generation/crash_generation_client.cc(10
1,11) :  error: field 'server_process_id_' will be initialized after field 
'crash_event_' [-Werror,-Wreorder]
          server_process_id_(0),
          ^
../../breakpad/src/client/windows/crash_generation/crash_generation_client.cc(10
5,11) :  error: field 'exception_pointers_' will be initialized after field 
'custom_info_' [-Werror,-Wreorder]
          exception_pointers_(NULL),
          ^
../../breakpad/src/client/windows/crash_generation/crash_generation_client.cc(12
0,11) :  error: field 'thread_id_' will be initialized
after field 'server_process_id_' [-Werror,-Wreorder]
          thread_id_(0),
          ^
../../breakpad/src/client/windows/crash_generation/crash_generation_client.cc(12
1,11) :  error: field 'server_process_id_' will be initialized after field 
'crash_event_' [-Werror,-Wreorder]
          server_process_id_(0),
          ^
../../breakpad/src/client/windows/crash_generation/crash_generation_client.cc(12
5,11) :  error: field 'exception_pointers_' will be initialized after field 
'custom_info_' [-Werror,-Wreorder]
          exception_pointers_(NULL),
          ^

../../breakpad/src/client/windows/crash_generation/crash_generation_server.cc(12
8,7) :  error: field 'client_info_' will be initialized after field 
'pre_fetch_custom_info_' [-Werror,-Wreorder]
      client_info_(NULL),
      ^

../../breakpad/src/client/windows/crash_generation/minidump_generator.cc(263,7) 
:  error: field 'dump_path_' will be initialized after
field 'process_handle_' [-Werror,-Wreorder]
      dump_path_(dump_path),
      ^
../../breakpad/src/client/windows/crash_generation/minidump_generator.cc(277,7) 
:  error: field 'callback_info_' will be initialized after field 'write_dump_' 
[-Werror,-Wreorder]
      callback_info_(NULL),
      ^

Original issue reported on code.google.com by sa...@chromium.org on 1 Jul 2015 at 1:21

GoogleCodeExporter commented 9 years ago 
Fixed in r1471

Original comment by thestig@chromium.org on 13 Jul 2015 at 6:27