search

StephenCleary / Comparers

The last comparison library you'll ever need!
MIT License
427 stars 33 forks source link

Avoid unnecessary dependencies in .NET 4.5 #5

Closed franklin-ross closed 7 years ago

franklin-ross commented 7 years ago

I've been using this package for a while and it's great, but when I recently added it to a .NET 4.5 app, it pulled in a whole lot of .NET standard dependencies (more than doubled my packages list), even though I don't believe it strictly needs them (could be wrong there).

From this SO post I'm guess it might be possible to create a package that only installs those dependencies if it needs them.

Thoughts?

StephenCleary commented 7 years ago

Yes, it's possible. But it's a lot of work, and I expect the RTM of the netstandard tooling to resolve this automatically.

If they don't, then I'll revisit this.

https://github.com/StephenCleary/AsyncEx/issues/84

franklin-ross commented 7 years ago

Yup, that's fair. I was thinking that might be in the works, considering it's a pretty broad issue and seems like it could be automated away.

StephenCleary commented 7 years ago

Agreed. I know they're planning for netstandard 2.0 to just have a single dll for all of netstandard. Not sure if that will be (or even can be) backported to netstandard 1.x.

But I'm hoping they'll fix up the netstandard tooling at least.