StephenCleary / Deque

Double-ended queue
MIT License
118 stars 25 forks source link

Add bulk add/remove/read methods using spans. #8

Open mpartel opened 1 year ago

mpartel commented 1 year ago
StephenCleary commented 1 year ago

I love the span APIs but I can't take the netstandard bump. Can you change this PR to multitarget instead?

mpartel commented 1 year ago

Done, I think (somewhat new to C# outside of Unity)

mpartel commented 1 year ago

Ping. Sorry for piling on more changes afterwards. Should be all done now.

mpartel commented 1 year ago

^ or so I thought :man_facepalming:

StephenCleary commented 1 year ago

Note to self: compare this API with https://github.com/dotnet/runtime/issues/1530

StephenCleary commented 1 year ago

.NET 8.0 just got span overloads for List<T>: InsertRange, AddRange, CopyTo.

https://devblogs.microsoft.com/dotnet/performance-improvements-in-net-8/

StephenCleary commented 1 year ago

Also should include CollectionBuilder in .NET 8.0.