search

StephenGrider / ReduxSimpleStarter

Starter pack for an awesome Udemy course
MIT License
3.56k stars 4.63k forks source link

Google maps API key error #82

Open TVScoundrel opened 7 years ago

TVScoundrel commented 7 years ago

Hi @StephenGrider, Not sure if it was left in on purpose but this line https://github.com/StephenGrider/ReduxSimpleStarter/blob/master/index.html#L6 makes a red warning appear in the console about the google maps API key not being set.

I would imagine that not every application needs google maps so I would assume that line could be removed from this repo.

It is also not being used by most of the apps built in your Udemy courses.

Cheers, Tom Van Schoor

gregt590 commented 7 years ago

Stephen:

Any reason the "" line is included in index.html from the start before it is described or needed?
As Tom mentions above, it generate a ""Google Maps API warning: NoApiKeys https://developers.google.com/maps/documentation/javascript/error-messages#no-api-keys" util.js:221:12" warning in the console log at every start.

scottwestover commented 7 years ago

Submitted a pull request for this issue https://github.com/StephenGrider/ReduxSimpleStarter/pull/167