StephenGrider / WebpackProject

Sample React Project for Handling Webpack Features
142 stars 130 forks source link

some faker version has a bug #3

Closed hirokihokari closed 5 years ago

hirokihokari commented 6 years ago

In master, package.json has faker included with the version ^3.1.0. Some claim that it caused TypeError: Cannot read property 'localPasswordGeneratorLibraryName' of undefined.

If others don't experience this, it might mean the bug was introduced somewhere in ^3.1.0 (If my understanding of notation is correct, 3.1.x).

This is fixed in 4.1.0 release(https://github.com/Marak/faker.js/commit/02be0dc61e0ff84bdbe975d66b09c6231b25542c), so I think it's safer to declare that in package.json instead.

If this sounds reasonable, I can make a PR.