search

StephenVinouze / KinApp

A Kotlin In App Purchase library that lets you easily manage your billing process in Android
Apache License 2.0
81 stars 13 forks source link

Better use of developer payload? #4

Open paritosh-gupta opened 6 years ago

paritosh-gupta commented 6 years ago

Hi there,

Is there a reason why the developer payload is passed to the Security Manager as the base64 public key?

I would rather have another variable in the constructor and let the user put whatever developer payload he wants.

https://github.com/StephenVinouze/KinApp/blob/fe0f61938a986fca57cbfeaa9c8db7963db4ce21/core/src/main/kotlin/com/github/stephenvinouze/core/managers/KinAppManager.kt#L137

https://github.com/StephenVinouze/KinApp/blob/5589ad60747ab4c39d04175f7f302af93d9d967e/core/src/main/kotlin/com/github/stephenvinouze/core/managers/SecurityManager.kt#L31

Thanks for the awesome library!!