Steppschuh / Java-Markdown-Generator

Java library to generate markdown
MIT License
230 stars 47 forks source link

fix: use platform indepentent line seperator #8

Closed sandrozbinden closed 6 years ago

sandrozbinden commented 6 years ago

Currently the created markdown uses hardcoded "\n" line seperators. This fix changes the behaviour to use the java System.lineSeperator() method that uses the correct line seperator according to the current os environment.

Closes #7

codecov[bot] commented 6 years ago

Codecov Report

Merging #8 into master will increase coverage by 0.3%. The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master       #8     +/-   ##
===========================================
+ Coverage     68.97%   69.28%   +0.3%     
- Complexity        0      182    +182     
===========================================
  Files            31       31             
  Lines           606      612      +6     
  Branches         64       46     -18     
===========================================
+ Hits            418      424      +6     
  Misses          168      168             
  Partials         20       20
Impacted Files Coverage Δ Complexity Δ
...eppschuh/markdowngenerator/list/UnorderedList.java 88.88% <100%> (ø) 11 <0> (+11) :arrow_up:
...pschuh/markdowngenerator/text/heading/Heading.java 57.69% <100%> (ø) 7 <0> (+7) :arrow_up:
...ppschuh/markdowngenerator/text/code/CodeBlock.java 91.66% <100%> (ø) 5 <1> (+5) :arrow_up:
...steppschuh/markdowngenerator/text/quote/Quote.java 81.81% <100%> (ø) 4 <0> (+4) :arrow_up:
.../net/steppschuh/markdowngenerator/table/Table.java 71.32% <66.66%> (ø) 26 <0> (+26) :arrow_up:
...huh/markdowngenerator/text/quote/QuoteBuilder.java 81.81% <0%> (+6.81%) 4% <0%> (+4%) :arrow_up:
.../markdowngenerator/text/code/CodeBlockBuilder.java 58.82% <0%> (+8.82%) 4% <0%> (+4%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 747334c...19e22ca. Read the comment docs.

Steppschuh commented 6 years ago

Thanks for your contribution!

sandrozbinden commented 6 years ago

@Steppschuh will there be a new version on maven central for this fix?

Steppschuh commented 6 years ago

Hey @sandrozbinden, sorry for the delay. The new version should be available here.