search

Sterc / SEOPro

The ultimate MODX Revolution SEO companion
https://www.sterc.nl/en/modx-extras
14 stars 29 forks source link

- Change type of modResource.description to be "text" #75

Closed bezumkin closed 6 years ago

bezumkin commented 6 years ago

This will allow to use long descriptions and don't wait for MODX 2.7 release

joeke commented 6 years ago

@bezumkin Nice solution Vasily! I did not know you could override the mapping OnMODXInit. Does this have any performance impacts?

bezumkin commented 6 years ago

Not at all, MODX loads this map into memory at each load - and we can change it without any impacts.

joeke commented 6 years ago

@bezumkin One note: in the description resolver on uninstall you revert the the description back to varchar(191), but modx versions prior to 2.6 had varchar(255). Maybe you could edit it so it gets the original fitting with the current modx version (from the schema perhaps)?

bezumkin commented 6 years ago

It was reduced in 2.6.1, but you right, I can check schema of current site.