search

Stereo101 / python-MidiToVirtualPianoMacro

Takes a midi file and converts it into a macro which will play the midi using virtualpiano.net. Uses pyHook and ctypes for macro execution.
96 stars 82 forks source link

Added tempo changing #62

Closed Raven13111 closed 3 months ago

atirut-w commented 4 months ago

Please be sure to create a feature branch next time you make a PR, unless you want to see merge or local-remote conflicts when someone commit to the master branch while your PR is not merged :+1:

Raven13111 commented 4 months ago

As an end user I don’t really see a point in this. And what is the feature trying to do? Speed is just an offset of pitch and tempo but since it a macro, pitch doesn’t matter so it just leave us with tempo. And the program already have speed control.

Some midis like rush e have it so it's changing constantly, this makes it sound fine or atleast better

Raven13111 commented 3 months ago

Closing pr