search

Stereowalker / Survive

https://modrinth.com/mod/survive
https://www.curseforge.com/minecraft/mc-mods/survive
Other
19 stars 18 forks source link

[Bug] Crash if loading with IguanaTweaks Reborn and Tough As Nails #200

Open MDMCK10 opened 2 years ago

MDMCK10 commented 2 years ago

MC Version: 1.16.5 Survive version: 1.16.5-3.4.6 Forge version: 36.2.26

Issue: Minecraft crashes if IguanaTweaks Reborn and Tough As Nails are used alongside Survive, looks to be mixin issues regarding FoodStats#nutritionHeal

Crash report: https://pastebin.com/raw/PXk6fj4T Latest log: https://pastebin.com/raw/vaDH8BSv

Related: https://github.com/Insane96/IguanaTweaksReborn/issues/177

Stereowalker commented 2 years ago

TaN is incompatible with Survive.

yellows111 commented 2 years ago

TaN is incompatible with Survive.

Seems to work on my side fine, until I add ITR.

There's probably something i'm missing in gameplay, but at least the game will load with those two in specfic if put together.

I've suspected that the mod (Survive) is trying to patch the net.minecraft.util.FoodStats function via a mixin (survive.mixins.json:FoodStatsMixin), while not checking the function it's trying to patch is already been patched by something else.

Stereowalker commented 2 years ago

If TaN is working with Survive, it would mean that TaN is no longer applying a mixin to FoodStats or they're found an alternative. If ITR is trying to mixin into FoodStats, then I'd have no other choice than to chalk it up as an incompatibility because the nutrition and thirst modules need to access/modify the heal method in FoodStats

MDMCK10 commented 2 years ago

I see, would it at least be possible to make it so these features are either automatically disabled or can be configured to do so if applying the mixin fails for any reason, instead of just causing the game to crash?

Also, opening an issue over at TaN's issue tracker very likely wouldn't result in this being fixed on their side, as they have dropped support for 1.16.5 as shown here: image