Stereowalker / tiered

Adds tiers/modifiers to tools.
https://www.curseforge.com/minecraft/mc-mods/tiered
Other
4 stars 4 forks source link

[1.19.2] Huge incompatability with Curios causing crash #91

Open CDRAGONN44 opened 1 month ago

CDRAGONN44 commented 1 month ago

Hello, I was adding curios (Version 5.1.6.3) to a custom modpack (Forge 43.3.0) when I noticed it kept on crashing. After reading crashlogs I found out it was because of Reforged (or Tiered) (Version 6.0.6). I decided to make a pack containing only the two mods, which again resulted crash. I noticed one message in the logs read: org.spongepowered.asm.mixin.injection.throwables.InjectionError: LVT in top/theillusivec4/curios/client/ClientEventHandler::onTooltip(Lnet/minecraftforge/event/entity/player/ItemTooltipEvent;)V has incompatible changes at opcode 282 in callback tiered.mixins.json:curios.ClientEventHandlerMixin->@Inject::storeAttributeModifier(Lnet/minecraftforge/event/entity/player/ItemTooltipEvent;Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfo;Lnet/minecraft/world/item/ItemStack;Lnet/minecraft/world/entity/player/Player;Ljava/util/List;Lnet/minecraft/nbt/CompoundTag;ILjava/util/Map;Ljava/util/Set;Ljava/util/List;Ljava/util/List;Lnet/minecraft/network/chat/MutableComponent;Lnet/minecraftforge/common/util/LazyOptional;Ljava/util/List;Ljava/util/Iterator;Ljava/lang/String;Lcom/google/common/collect/Multimap;ZLjava/util/Iterator;Ljava/util/Map$Entry;Lnet/minecraft/world/entity/ai/attributes/AttributeModifier;) which makes me believe that where this change is made is what is causing the crash. I also noticed that Version 6.0.3 is compatible with Curious while 6.0.4 and beyond are not. Thank you. Crashlog: crash-2024-07-24_22.47.20-fml.txt

CDRAGONN44 commented 1 month ago

After researching this issue, I came across #83 and I believe that 1.19.2 may need to be in a separate file from 1.20 and beyond due to code changes and code removal which end up removing compatability with curios. For now, I guess I'll have to use version 6.0.3 unless I can find a solution or an update for 1.19.2 fixing the issue is made.