search

Stericson / RootTools

RootTools Library
1.6k stars 484 forks source link

RootShell: use jitpack dependency instead of aar file #87

Closed juanitobananas closed 5 years ago

juanitobananas commented 5 years ago

Using jitpack.io might solve #84. It will hopefully be able to know that it has to download 1.6 and not 5.0, though I am not sure.

JcChimjj commented 5 years ago

87

JcChimjj commented 5 years ago

87

JcChimjj commented 5 years ago

84

JcChimjj commented 5 years ago

87

Stericson commented 5 years ago

@JcChimjj @juanitobananas Is this still a WIP? Any confirmation of whether proper version is fetched?

juanitobananas commented 5 years ago

Is this still a WIP?

Actually, it was just a very non-accurate way of naming the pull request :wink:

Any confirmation of whether proper version is fetched?

I just created a 5.1 release in my fork and added the jitpack dep to a project of mine (with implementation 'com.github.juanitobananas:RootTools:5.1') and it imported it correctly. So it actually seems to solve #84 :smile:

By the way, after rebasing to the latest upstream I had to add 1537e44fcf7d93605284b849a765df93a79a1b6d to it, as the current upstream was not buildable. Strictly it wouldn't belong to this pull request, but I just added on top of it. If you prefer it somewhere else, or wish to have it otherwise resolved, just say so :blush:

Stericson commented 5 years ago

Sounds good to me. Thanks :+1: Used to using Gitlab which won't let you merge a MR marked as WIP.

juanitobananas commented 5 years ago

No problem! :+1: