SterlingPeet / cookiecutter-fprime-deployment

Cookiecutter template for creating new deployments within an F Prime project/repository
Other
4 stars 0 forks source link

Incorrect Use of Baremetal Scheduler Flag in Deployment Level CMakeLists.txt for Fprime 2.X #12

Open EbenezerA99 opened 2 years ago

EbenezerA99 commented 2 years ago

In the deployment level CMakeLists.txt, the following line is used to specify whether the Baremetal Scheduler should be used for a specific deployment:

set(BAREMETAL_SCHEDULER CACHE BOOL ON "Uses the baremetal scheduler")

However, with Fprime 2.0, the flag that specifies the use of the baremetal scheduler is actually FPRIME_USE_BAREMETAL_SCHEDULER, necessitating that the new line in the deployment Cmakelists.txt be something like:

set(FPRIME_USE_BAREMETAL_SCHEDULER ON).

Within the repository, the cookiecutter should check to see if the user has specified a baremetal deployment and then set the variable as necessary here, along these lines:

{% if cookiecutter.deployment_baremetal_scheduler == "yes" -%} set(FPRIME_USE_BAREMETAL_SCHEDULER ON) {%- endif %}

SterlingPeet commented 2 years ago

Do we know for sure that this is variable name was changed? In other words, do you think I can blindly change this variable name with no adverse consequences or do you think we need to keep the old variable too?

EbenezerA99 commented 2 years ago

I did a search of the entire repo and don't see them using the BAREMETAL_SCHEDULER variable at all anymore, they only use this: FPRIME_USE_BAREMETAL_SCHEDULER.