search

SterlingYM / astroPIPS

A set of tools for photometric analysis. Determines the period of short-period variable stars.
https://pips.readthedocs.io/en/latest/
MIT License
7 stars 0 forks source link

Missing /2 in amplitude spectrum? #32

Closed arjunsavel closed 3 years ago

arjunsavel commented 3 years ago

In tossing a simple sine wave through the amplitude spectrum function, it seems as though it returns twice the amplitude at the given period. Potential bug, or have I missed something?

Screen Shot 2021-02-28 at 7 57 53 PM

SterlingYM commented 3 years ago

This is due to the convention in pulsating variable star studies to call peak-to-peak magnitude difference the amplitude. What is the convention in the exoplanet community?

arjunsavel commented 3 years ago

Pretty sure we use half peak-to-peak magnitude! It'd be fine to keep this magnitude implementation in, though, so long as it's documented as such.