search

SterlingYM / astroPIPS

A set of tools for photometric analysis. Determines the period of short-period variable stars.
https://pips.readthedocs.io/en/latest/
MIT License
7 stars 0 forks source link

Make multiprocessing optional? #4

Closed arjunsavel closed 2 years ago

arjunsavel commented 4 years ago

Not all users might want to use multiprocessing — especially if they're running scripts that spawn processes, themselves.

SterlingYM commented 3 years ago

We should look into more efficient and careful implementation methods for multiprocessing (e.g. #14). I'll take care of this

SterlingYM commented 3 years ago

Multiprocessing seems to be very unstable on different platforms. We should definitely make it easier to turn multiprocessing off entirely, probably by adding a new PIPS configuration class or something

SterlingYM commented 3 years ago

So far multiprocessing=False argument turns off multiprocessing in periodogram() and get_period() functions. Should we add global parameter? Another easy implementation is to add attributes to photdata class.