Sterncat / opticspy

python optics module
MIT License
458 stars 127 forks source link

Not functional under python 3.6 #20

Open cbuhl opened 6 years ago

cbuhl commented 6 years ago

Hi there,

I'm trying to use your software under python 3.6, but it is really not refactored to work. The print statements I've come across so far do not have ()'s, so it doesn't run.

Also, the issue previous issue with the import errors stem from this, I think.

I'm running it from a mac, if it matters, but I don't think it makes a difference.

I'm really hoping to use it, however!

cbuhl commented 6 years ago

I can confirm that it works with python 2.7.

medix commented 6 years ago

I can confirm that the platform / OS does not make a difference. I'm working on two different systems in an attempt to resolve the problem to no avail. I was originally trying to get the zernikeapp working when I first encountered the same error (using Python3 as I can't seem to get PyQt5 installed for Python 2.7).

Sterncat commented 6 years ago

The reason I chose Python2.7 is some package two years ago no works really well in 2015. But now, I think it is time to move. I hope I have more time to rework on this. I think python version mainly have the difference for the "print" and "import" issues. And system issue is mainly on the file system difference. I developed it under mac/linux.

Thanks!

2018-03-18 7:42 GMT-07:00 medix notifications@github.com:

I can confirm that the platform / OS does not make a difference. I'm working on two different systems in an attempt to resolve the problem to no avail. I was originally trying to get the zernikeapp working when I first encountered the same error (using Python3 as I can't seem to get PyQt5 installed for Python 2.7).

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Sterncat/opticspy/issues/20#issuecomment-374004751, or mute the thread https://github.com/notifications/unsubscribe-auth/ACiIhXW6yYLQviGof_xftwa9dhtwNxgsks5tfnJtgaJpZM4STT5m .

medix commented 6 years ago

Thanks for the information. I do not know Python that well, but from what I can tell so far, the issues are as you said: mostly related to the print function and the differences for local/global referencing of package imports (different in 2.7 as compared to 3.6).

I am also developing under OSX but also under Win10 and have found the same general behavior on both platforms.

I also noted a few problems with newer versions of numpy and matplot lib, though at the moment I can't recall what they were. I'll post back here when I can reproduce the errors..

goldengrape commented 6 years ago

I tried:

mkdir /tmp/github/
cd /tmp/github/
git clone https://github.com/Sterncat/opticspy.git
pip install -e opticspy

It works in python3.5

However, pip install opticspy

It reports:

ModuleNotFoundError                       Traceback (most recent call last)
<ipython-input-2-c4f9d50221f9> in <module>()
      1 get_ipython().run_line_magic('matplotlib', 'inline')
----> 2 import opticspy

~/anaconda3_501/lib/python3.6/site-packages/opticspy/__init__.py in <module>()
     10 """
     11 from __future__ import division as __division__
---> 12 import aperture, interferometer_seidel,interferometer_zenike
     13 import seidel, seidel2, zernike, test, tools, diffraction, jones, gauss
     14 import phaseunwrap, lens, asphere, mplot3d, zernike_rec

ModuleNotFoundError: No module named 'aperture'

Maybe it is not update in PyPI?

goldengrape commented 6 years ago

Can you build an anaconda package please? @Sterncat Thank you

goldengrape commented 6 years ago

Oh, I see. This works pip install git+git://github.com/Sterncat/opticspy.git@master