Sterophonick / SimpleLight

Custom theme for the EZ-Flash Omega
Apache License 2.0
133 stars 23 forks source link

Update to Goomba 2019-05-04 #4

Closed veikkos closed 4 years ago

veikkos commented 4 years ago

Hi!

As you probably noticed I patched latest Goomba 2019-05-04 to my kernel fork. There was a request in Reddit from user of your kernel to update Goomba also to your kernel. Would you like that I'd make a Pull Request?

Sterophonick commented 4 years ago

Yeah, I saw that! That was amazing! Please do!

Sterophonick commented 4 years ago

I got it in. Thank you for doing this!

veikkos commented 4 years ago

I got it in. Thank you for doing this!

You were quick, I didn't even have time to make a PR!

Unfortunately I'm having a problem with your fork in general. I flashed your ezkernel-light.bin and ezkernel-dark.bin from master, but it always gets stuck when trying to start a game. Something about "Saver error, SD Card" (it's bit hard to read it).

Same issue happens if compiling kernel locally. Kernel menus work fine. No matter if I try Dark/Light or reflash, always the same. When restoring official kernel or my fork it again works ok.

Have you tried that it works for you? Because of that issue I wasn't able to test the updated Goomba.

Sterophonick commented 4 years ago

Your saves are corrupted. You need to clean off your SD card with chkdsk or some equivalent. Back. Up. Your. Saves.

On Sun, Feb 9, 2020, 8:51 AM Veikko Soininen notifications@github.com wrote:

I got it in. Thank you for doing this!

You were quick, I didn't even have time to make a PR!

Unfortunately I'm having a problem with your fork in general. I flashed your ezkernel-light.bin and ezkernel-dark.bin from master, but it always gets stuck when trying to start a game. Something about "Saver error, SD Card" (it's bit hard to read it).

Same issue happens if compiling kernel locally. Kernel menus work fine. No matter if I try Dark/Light or reflash, always the same. When restoring official kernel or my fork it again works ok.

Have you tried that it works for you? Because of that issue I wasn't able to test the updated Goomba.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Sterophonick/SimpleLight/issues/4?email_source=notifications&email_token=AIJQSTHQY2JE2IAMWADQ5XTRCARBNA5CNFSM4KSA63B2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELGP7TY#issuecomment-583860175, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIJQSTFHX67DIL2PNVM27RDRCARBNANCNFSM4KSA63BQ .

veikkos commented 4 years ago

I'm not sure how my saves work after restoring original kernel or mine? I also tried to rename "SAVER" folder so that it would be re-created, but it didn't help. I'll see if I can find another SD card to experiment more freely. Good if everything works for you. 👍

Also, please consider updating version number, any release notes/manual and ezkernel-light.bin and ezkernel-dark.bin to avoid any confusion.

Sterophonick commented 4 years ago

Uh, chkdsk might help with the saves.

On Sun, Feb 9, 2020, 9:03 AM Veikko Soininen notifications@github.com wrote:

I'm not sure how my saves work after restoring original kernel or mine? I also tried to rename "SAVER" folder so that it would be re-created, but it didn't help. I'll see if I can find another SD card to experiment more freely. Good if everything works for you. 👍

Also, please consider updating version number, any release notes/manual and ezkernel-light.bin and ezkernel-dark.bin to avoid any confusion.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Sterophonick/SimpleLight/issues/4?email_source=notifications&email_token=AIJQSTED57R44RBCVY62GK3RCASM3A5CNFSM4KSA63B2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELGQL6Q#issuecomment-583861754, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIJQSTBGRINUC3AMOSJ23RLRCASM3ANCNFSM4KSA63BQ .

veikkos commented 4 years ago

My saves are fine. They work ok with official or my kernel. I'll open another issue for what I have.