search

Steve-Mcl / node-red-contrib-cron-plus

A flexible scheduler node for Node-RED (featuring full dynamic control, sunrise/sunset by location and Timezone support)
MIT License
45 stars 12 forks source link

Please use properly name-spaced CSS classes and element ids #6

Closed knolleary closed 4 years ago

knolleary commented 4 years ago

This node introduces a lot of CSS styles for very generically named classes and elements. This means it is highly likely to clash with other nodes and elements and cause rendering issues.

For example: form-tip, #map etc.

Nodes should use properly namespaced CSS and element IDs to ensure they don't cause unintended clashes.

For example, instead of giving an element an id of map, it ought to be cron-plus-map.

And form-tip should be cron-plus-form-tip.

Steve-Mcl commented 4 years ago

fixed in 6a35f82 (v0.6.7)