Swifty, swifter, the swiftest

SteveBarnegren / SwiftChess

Chess engine and AI written in Swift

MIT License

145 stars 35 forks source link

Swifty, swifter, the swiftest #2

Closed sochalewski closed 6 years ago

sochalewski commented 6 years ago

Hi,

I really like your repo and I am going to use it in my game.

So I've decided to make it swifter changing:

function naming convention
access level for some properties
throwing errors when desired
added interop between Swift 3.2 and 4.0

SteveBarnegren commented 6 years ago

@sochalewski Thanks for taking the time to do this

All of the changes look great to me, much more Swifty! This was my first real Swift project coming from Obj-C, so the api didn't quite follow the best practice Swift style!

Merged 👍

SteveBarnegren commented 6 years ago

Released to Cocoapods as v0.3.0