Cayenne py improvements

SteveCossy / IOT

Range of Internet of Things - related projects

1 stars 3 forks source link

Cayenne py improvements #1

Closed shermp closed 4 years ago

shermp commented 4 years ago

Hi Steve,

Am opening this pull request as an example to show you how it all works.

Just made a couple of improvements to start with. I'll mark this as a 'draft' PR, as I might have a few more changes to make yet,

shermp commented 4 years ago

I was thinking of using an actual config format like TOML. There is a python library https://pypi.org/project/toml/ to load/save TOML files.

EDIT: The initial config file could contain something as simple as

# Authentication settings to connect to Cayenne
[cayenne]
mqtt_clientid = "client id string"
mqtt_user = "mqtt user string"
mqtt_password = "mqtt password string"

EDIT2: Also, have a look at this syntax guide if you want to format your GitHub comments.

SteveCossy commented 4 years ago

Good Markdown summary. Does point to where YAML got its name from! I think I've finally got the Client-ID requirements sused!

The Auth Client-ID must be unique! This is use to log in. The reason I was getting disconnects last night was that I was using the same Client-ID as the that used by the publishing script.
The SUB Client-ID must be the one Cayenne specify. Obviously this is not going to be unique, it must be the one from the Cayenne dashboard.

Really love the pull request. Have made a few more changes, and merged this request into my master.

Thanks! :-)

shermp commented 4 years ago

You may not have noticed, but this was all done in your repository. I took the opportunity as a collaborator to push to this repository, rather than forking it to my account.

YAML has nothing to do with markdown BTW. Markdown is a way of easily formatting/structuring text, where is YAML is a language for writing configurations.

(Also, I've recently been learning Ansible. YAML is the worst...)