search

SteveDoyle2 / pyNastran

A Python-based interface tool for Nastran's file formats
Other
384 stars 147 forks source link

Update add_card.py to fix error where X is being written as integer i… #792

Closed romagnoliFer closed 1 month ago

romagnoliFer commented 1 month ago

x must be changed from list of int to list of float, otherwise nastran assumes this is the GO field not the X1, X2, X3.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.09%. Comparing base (9afdbed) to head (c5e3b42).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/SteveDoyle2/pyNastran/pull/792/graphs/tree.svg?width=650&height=150&src=pr&token=S1ely2b7bK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Steven+Doyle)](https://app.codecov.io/gh/SteveDoyle2/pyNastran/pull/792?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Steven+Doyle) ```diff @@ Coverage Diff @@ ## main #792 +/- ## ========================================== - Coverage 76.45% 74.09% -2.36% ========================================== Files 697 565 -132 Lines 267325 192295 -75030 Branches 33655 25546 -8109 ========================================== - Hits 204375 142488 -61887 + Misses 55371 43575 -11796 + Partials 7579 6232 -1347 ``` | [Files](https://app.codecov.io/gh/SteveDoyle2/pyNastran/pull/792?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Steven+Doyle) | Coverage Δ | | |---|---|---| | [pyNastran/bdf/bdf\_interface/add\_card.py](https://app.codecov.io/gh/SteveDoyle2/pyNastran/pull/792?src=pr&el=tree&filepath=pyNastran%2Fbdf%2Fbdf_interface%2Fadd_card.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Steven+Doyle#diff-cHlOYXN0cmFuL2JkZi9iZGZfaW50ZXJmYWNlL2FkZF9jYXJkLnB5) | `81.98% <ø> (ø)` | | ... and [254 files with indirect coverage changes](https://app.codecov.io/gh/SteveDoyle2/pyNastran/pull/792/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Steven+Doyle) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/SteveDoyle2/pyNastran/pull/792?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Steven+Doyle). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Steven+Doyle) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/SteveDoyle2/pyNastran/pull/792?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Steven+Doyle). Last update [9afdbed...c5e3b42](https://app.codecov.io/gh/SteveDoyle2/pyNastran/pull/792?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Steven+Doyle). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Steven+Doyle).