search

SteveEisner / WLEDtubes

Control WS2812B and many more types of digital RGB LEDs with an ESP8266 or ESP32 over WiFi!
https://kno.wled.ge
MIT License
23 stars 2 forks source link

revert the revert to update FastLED packages #29

Closed craiglink closed 2 months ago

craiglink commented 2 months ago

The issue with ESPnow syncing was causes because I disabled it in the Tubes build when I was trying to get the new version of the ESPnow library working with the code base. I mistakenly didn't realized that the Tubes plugin used the based ESPnow libraries as well.

Removing this line fixes syncing while still having the new libraries

I also added a default to the env:esp32_quinled_dig2go_tube build to support 150 LEDs

SteveEisner commented 2 months ago

Hmm I thought I had tried just removing that define! But I was having trouble getting various targets to build so maybe I just missed that it had re-enabled syncing.

In the main branch, they're working on replacing QuickEspNow right now so we might be able to re-implement on top of their (smaller) version soon. But we'll want to make sure we can still get all the RSSI info!

softhack007 commented 1 month ago

@craiglink @SteveEisner just a hint on why upstream is not using arduino-esp32 v2.0.17:

Actually my recommendation would be to stay on arduino-esp32 v2.0.14 - or even v2.0.9. For all variant, including S3, C3 and classic esp32.

If you want to use audioreactive, you could change this line

https://github.com/SteveEisner/WLEDtubes/blob/ee318dc9b886a57c4f4762cb2a193832798d8aa1/usermods/audioreactive/audio_source.h#L74

to 

#if (ESP_IDF_VERSION >= ESP_IDF_VERSION_VAL(4, 4, 0)) && (ESP_IDF_VERSION <= ESP_IDF_VERSION_VAL(4, 4, 8))

This extends the "swapped channel workaround" to be compatible with the latest platform version.

SteveEisner commented 1 month ago
  • new bugs, for example: serial usb gets stuck randomly, SD driver problems, slower SPI bus, bigger firmware size, audioreactive reads from wrong channels (right instead of left).

Thanks - we learned about the larger firmware size in the discord, so I did some debugging to understand where that space was going. It's pretty unfortunate that they've ballooned the size of the wifi & crypto modules in 4.0+. It's stuff we don't need & could in theory compile out of the IDF to restore the space. But buggy USB and SD etc seems really bad :(

Actually my recommendation would be to stay on arduino-esp32 v2.0.14 - or even v2.0.9. For all variant, including S3, C3 and classic esp32.

I take it that you haven't made a joint conclusion about this with core WLED? (I know MM and core don't always agree :) ) I think the 0_15 branch has S3 and C3 at later arduino versions but classic esp32 remains at arduino 2.X. Maybe that's just for beta testing.