search

SteveHanna / Namecheap-dot-net

A .NET wrapper for the Namecheap API
MIT License
17 stars 13 forks source link

Add parameters for NameCheapApi.Domains.GetList() method #18

Open Awkward147 opened 5 years ago

Awkward147 commented 5 years ago

Currently it is the default method. But it can have parameters.

Atleast, PageSize.

image

https://www.namecheap.com/support/api/methods/domains/get-list.aspx

philipmat commented 5 years ago

@Awkward147 - we'd welcome a PR if you have the time to take a shot at it.

Awkward147 commented 5 years ago

Oh Boy, Never done this. But I kinda need namecheap api for the app I am doing. And I dont wanna do what you have done :D I guess I will try to upgrade this method.

To be clear. In this case it is enough to just overload GetList method, adding parameters that namecheap api can take, and thats it?

philipmat commented 5 years ago

Yeah, you got the right idea.
Fork the repo, create a new branch if you plan to make more contributions, overload GetList.

Add a test for it too, please; if that's not something you feel comfortable doing, that's ok -- I'll add it (although that discomfort is actually exactly why you should give it a shot 😄 )

Thank you. If there are any other methods you feel could use overloads, please open an issue for each so we can add them over time.

LukasCRMarketing commented 5 years ago

Hi, it is me again. Just from work github account. Got distracted by some other project.

Anyway, I forked repo, overloaded the method and so on. I am trying to write the test. Never done it before, but now I understand that I should have been doing them from the start.

So yea, to do the tests, I need to have a namecheap sandbox account with api access, right? And fill in the details in the json file included in the project?