SteveKunG / FishOfThieves

A mod adds all the fish from Sea of Thieves, fish fer ye pirate
https://www.curseforge.com/minecraft/mc-mods/fish-of-thieves
MIT License
17 stars 4 forks source link

Is it normal it adds overhead in the Nether? #36

Closed enmumne closed 1 year ago

enmumne commented 1 year ago

8o;p9;

I'm over the Nether ceiling testing some stuff... This shows up second in the profiler.

Why should it addFishSpawn here?

SteveKunG commented 1 year ago

All dimensions are already stay loaded, if there are structures around spawn chunk which allows fishes to spawn. addFishSpawn method would be executed. I've move addFishSpawn method to SpawnHelper class instead of ChunkGenerator. Hopefully it solves minor performance issue.