search

SteveKunG / FishOfThieves

A mod adds all the fish from Sea of Thieves, fish fer ye pirate
https://www.curseforge.com/minecraft/mc-mods/fish-of-thieves
MIT License
17 stars 4 forks source link

[1.20.1] Mixin injecting SynchedEntityData into entities not owned by Fish of Theves is dangerous #44

Closed TelepathicGrunt closed 9 months ago

TelepathicGrunt commented 11 months ago

Entity Data Accessors should only be ever set by the creator of the entity. Never added to by other mods.

The reason for this is because Entity Data Accessors are order dependent so if multiple mods tries to add these entity data accessors to mobs and on client, they run in a different order than the server did (because mod load order is not guaranteed), the client will get forcibly disconnected from server when the entity spawns.

Instead, this mixin part needs to be removed and migrated properly to a Forge Capability because capabilities were designed specifically for this use case of attaching data to arbitrary entities. It is safer for mods as the vanilla system is designed specifically only for vanilla and unsafe for mods. Then you would use your own packet to send the data to client when needed.

https://github.com/SteveKunG/FishOfThieves/blob/b0e8e1e7debcb25bd7ac3674765252c140dfca4c/common/src/main/java/com/stevekung/fishofthieves/mixin/animal/MixinAbstractFish.java#L31

This is especially a problem in large modpacks where many mods are doing this. Example is TNPLimitless 7 where there's many mods injecting SynchedEntityData onto entities and are getting out of order due to mod load order. Which is causes a lot of reports of people getting disconnected from server due to: image

SteveKunG commented 9 months ago

Hey! I just got time to revert this silly feature to their old behavior like parrot does. Should be fixed in the next release.