search

SteveKunG / FishOfThieves

A mod adds all the fish from Sea of Thieves, fish fer ye pirate
https://www.curseforge.com/minecraft/mc-mods/fish-of-thieves
MIT License
17 stars 4 forks source link

Crash at during loading world with MineColonies #5

Closed agentwolf88 closed 2 years ago

agentwolf88 commented 2 years ago

crash-2022-03-23_10.59.46-server.txt

SteveKunG commented 2 years ago

Are you really sure that caused by this mod? I see at com.minecolonies.coremod.colony.crafting.LootTableAnalyzer.toDrops(LootTableAnalyzer.java:58) ~[minecolonies-1.18.2-1.0.526-ALPHA.jar%23135!/:1.18.2-1.0.526-ALPHA] {re:classloading} in a crash report.

agentwolf88 commented 2 years ago

Its maybe incompatible with Minecolonies? I have reported to the devs too.

agentwolf88 commented 2 years ago

Minecolonies dev said: Fish of Thieves seems to be doing somethinkg funky with their loot tables. raise an issue on their github.

SteveKunG commented 2 years ago

After testing I found the problem on my own LootTableLoadEvent, especially this line. https://github.com/SteveKunG/FishOfThieves/blob/1.18.x_architectury/forge/src/main/java/com/stevekung/fishofthieves/forge/proxy/CommonProxyForge.java#L89

Not really sure why, I will find a way to fix this later.

SteveKunG commented 2 years ago

Fixed in 1.0.4!