search

SteveKunG / SkyBlockcatia

Useful Hypixel Skyblock features, QOL and In-game API Viewer
https://www.curseforge.com/minecraft/mc-mods/skyblockcatia
MIT License
31 stars 9 forks source link

Fishing Rod line override causing issues where other mods. #33

Closed ThatGravyBoat closed 3 years ago

ThatGravyBoat commented 3 years ago

Can you please change your RenderFishMixin to do something similar to how its being done in NotEnoughUpdates where its injected at the front and if the conditions are meet it will cancel the method meaning it will cancel the vanilla method but not your injected method and will run your code for rendering you can see an example of this here. https://github.com/Moulberry/NotEnoughUpdates/blob/beta/src/main/java/io/github/moulberry/notenoughupdates/mixins/MixinRenderFish.java This change will allow players to use such features as the coloured fishing rod lines which is in NEU, I just hate to see players not getting the full experience of mods because of incompatibilities. Thanks for reading and I hope this change can be added!

SteveKunG commented 3 years ago

Yeah it was my own private mod before, so removed it all should solve all issues. :D Fixed in https://github.com/SteveKunG/SkyBlockcatia/commit/0e4834f2d9863a58f1117e26129bb37e30e5e581

SteveKunG commented 3 years ago

You can also get experimental build in my discord : https://discord.gg/54VqgZb

SteveKunG commented 3 years ago

Fixed in 1.0.13.