SteveLTN / https-portal

A fully automated HTTPS server powered by Nginx, Let's Encrypt and Docker.
MIT License
4.45k stars 295 forks source link

Fix timeout of acme_tiny (again) #236

Open leonmarkus opened 4 years ago

leonmarkus commented 4 years ago

Sadly #225 still wasn't enough for me. All certificates that had to be renewed failed (no DNS changes at all). Increasing the timeout yet again from 60 to 180 seconds solved the issue for me.

Is there something speaking against a long timeout? Let's maybe stick with a higher number like 180 or even 300 just to be sure?

SteveLTN commented 4 years ago

Wow, that's quite a long time for visiting a website! I'm afraid the chances are, you have something weird with our website. It's just a request form LE's server to your website, it should definitely not take that long! I don't think indefinitely increasing the timeout is a good idea to that.

Yes, there is a draw back to a long timeout. People who actually have the configuration wrong (e.g. has firewall blocking the port) will need to wait forever to discover their problems.

If you insist on a long timeout, you are always welcome to fork the project and build you own image :-) But I think you shouldn't do that. I would try visiting the ACME verification URL from somewhere else, to see what exactly is taking so long.