search

SteveLTN / https-portal

A fully automated HTTPS server powered by Nginx, Let's Encrypt and Docker.
MIT License
4.41k stars 295 forks source link

links is not needed in docker-compose.yml #340

Closed bburtin closed 7 months ago

bburtin commented 8 months ago

I believe that the links sections in your docker-compose.yml samples are not necessary:

  links:
    - wordpress

According to the Docker docs, the links feature is deprecated and has been replaced by Docker networks. The way I understand it, if you have a single docker-compose.yml file and don't define a network, all of the containers will implicitly be put on the same network and will be able to talk to each other. My https-portal container was able to talk to my web server without specifying network or links.

Also, thank you for making this container available! It has saved me countless hours dealing with configuring HTTP certificates.

SteveLTN commented 7 months ago

You are right. Tested to work. I'm removing the links from the README. Thanks!

bburtin commented 7 months ago

Sounds great, thanks!