feature request: multi-line domain environment variable

[rogervdf]

Thank you for this repo @SteveLTN we use it for quite a lot of services in production

Right now the package chokes on multi-line environmental variables, which docker-compose supports with |-

version: '3.7'

services:

  https-portal:
    image: steveltn/https-portal:1
    ports:
      - '80:80'
      - '443:443'
    restart: always
    environment:
      DOMAINS: |-
        'domain1.systems -> http://container1:80,
        domain2.xyz -> http://container2:80'

The error specifically:

https-portal_1 | Error: Invalid descriptor domain1.systems -> container1:80

It seems the parsing doesn't like when it is being passed the multi-line

Would you be able to add multi-line support on the domain environment variable? It would make using your package for large numbers of domains easier to maintain; scrolling up and down a long line to find the right domain and container takes time.

[SteveLTN]

I’m pretty sure it does support multi line as I use this format personally. Try to tweak the variable. Maybe remove the quotes. I’ll give you an example when I have my computer.

On Sun, Jan 21, 2024 at 9:35 PM rogervdf @.***> wrote:

Thank you for this repo @SteveLTN https://github.com/SteveLTN we use it for quite a lot of services in production

Right now the package chokes on multi-line environmental variables, which docker-compose supports with |-

version: '3.7'

services:

https-portal: image: steveltn/https-portal:1 ports:

• '80:80'
• '443:443' restart: always environment: DOMAINS: |- 'domain1.systems -> http://container1:80, domain2.xyz -> http://container2:80'

The error specifically:

https-portal_1 | Error: Invalid descriptor domain1.systems -> container1:80

It seems the parsing doesn't like when it is being passed the multi-line

Would you be able to add multi-line support on the domain environment variable? It would make using your package for large numbers of domains easier to maintain; scrolling up and down a long line to find the right domain and container takes time.

— Reply to this email directly, view it on GitHub https://github.com/SteveLTN/https-portal/issues/349, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD4AZ6HNFNVHPNH7SOQFJDYPUKRTAVCNFSM6AAAAABCD7YX3OVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA4TENJYHA4TSMY . You are receiving this because you were mentioned.Message ID: @.***>

[SteveLTN]

This is what I was using:

DOMAINS: > 
  admin:pass@local.example.com -> echo:8080,
  https-portal-redirection.example.com => https-portal-test.example.com,
  https-portal-nonexit.example.com

[rogervdf]

Ah, it was the ' indeed - thank you, tested and works!