search

SteveLTN / https-portal

A fully automated HTTPS server powered by Nginx, Let's Encrypt and Docker.
MIT License
4.41k stars 295 forks source link

Update nginx version? #356

Closed datWeazel closed 1 week ago

datWeazel commented 2 weeks ago

Hi, thank you for your work. We are often using your Dockerimage and it works great. We want to bring to your attention that there are some vulnerabilities with the nginx version 1.23.1 that is currently used. Are you planning to release a new build with an updated nginx version?

I already forked the project and I'm trying to update the nginx version but currently there seem to be some minor things that prevent the image from being build successfully. If I can manage to update everything I could open a PR but since I can't make any promises I wanted to ask if you are maybe working on an update yourself.

datWeazel commented 2 weeks ago

Opened a PR #357

SteveLTN commented 2 weeks ago

Hi, thanks for the PR! I will have a look!

On Mon, Jun 17, 2024 at 9:29 PM Timo Peters @.***> wrote:

Opened a PR #357 https://github.com/SteveLTN/https-portal/pull/357

— Reply to this email directly, view it on GitHub https://github.com/SteveLTN/https-portal/issues/356#issuecomment-2173401831, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD4AZ5ONODJNR6T4ARPJW3ZH3QD5AVCNFSM6AAAAABJNZWSB2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZTGQYDCOBTGE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

SteveLTN commented 1 week ago

@datWeazel Hi! After two days of testing, the cert renewal works fine. And I released 1.24.0. I'm closing this ticket. Thanks for the help!

datWeazel commented 1 week ago

Glad everything works now even tho it wasn't that straight forward and the changes were quite substantial.