search

SteveLane / hugo-icon

Icon theme for Hugo
MIT License
87 stars 67 forks source link

in team section, adding 4th and 5th persons , they are not correctly align into 2 rows. #18

Closed gianghn closed 5 years ago

SteveLane commented 6 years ago

Not sure what you mean. When I add the 4th and 5th, I get two rows of cards. Can you show a screenshot?

zkamvar commented 5 years ago

I ran into this problem as well. Here's a screencap:

image

SteveLane commented 5 years ago

Interesting. I'd guess this is an issue with the base html5 theme.

As a test, if you 'pad' the descriptions for each contact so that they are the same length, what happens?

zkamvar commented 5 years ago

The thing is, it's really difficult to pad these boxes with the given content. However, if I have an identical component, then it aligns as expected: image

SteveLane commented 5 years ago

Hi @zkamvar I've made a fix in the fix-for-flex branch. Can you please pull down that branch and try it out?

SteveLane commented 5 years ago

Hi @zkamvar and @gianghn have you checked this? I'd like to close this issue.

zkamvar commented 5 years ago

Hi @SteveLane, thanks for your patience. When I use the code from 3519332, the cards are aligned but the color is gone and the menu header is narrower and left-justified:

image

For reference, here's what the site looked like with the old version of hugo-icon:

image

SteveLane commented 5 years ago

@zkamvar the first image is what it should look like given the default styling. All I could suggest is that maybe you adjusted some of the CSS in styles.css for your particular site, which get overwritten when you pull in those changes. In my testing, changing background colours etc works with no other side effects.

TzZek commented 5 years ago

@SteveLane , I've applied your changes in the branch fix-for-flex and it's working good for me now, thanks for that!

SteveLane commented 5 years ago

Thanks @TzZek I'll merge it in.