search

SteveMacenski / slam_toolbox

Slam Toolbox for lifelong mapping and localization in potentially massive maps with ROS
GNU Lesser General Public License v2.1
1.67k stars 525 forks source link

adding namespace support for map saving #613

Closed SteveMacenski closed 1 year ago

SteveMacenski commented 1 year ago

Per https://github.com/SteveMacenski/slam_toolbox/issues/607

hilary-luo commented 1 year ago

@SteveMacenski Can this fix be merged? Users are continuing to run into this issue.

SteveMacenski commented 1 year ago

@hilary-luo I believe I left this asking someone experiencing this issue to test this PR to make sure it resolves their issues (to make sure there aren't other problems afoot as well). If someone tests this for that situation and gives it the thumbs up, I can merge and backport for a release!

Folks commented in https://github.com/SteveMacenski/slam_toolbox/issues/607 but didn't give me an indication that they tested (and then fell off my radar, as most of my work is event-driven)

hilary-luo commented 1 year ago

Thanks Steve. @NachtaktiverHalbaffe are you able to test this?

NachtaktiverHalbaffe commented 1 year ago

Sorry for the late reply. I'll try to test this when im back at University where my setup is located (Problem occured in my master thesis). Cant give a time estimation because I have to setup a completly new workspace/Docker environment (will be an humble environment because TB4 etc. runs on humble) to seperate everything from the current working setup. Try to get this done this month, have to fulfill some other deadlines for my thesis though and this topic isnt a top priority for my supervisor because he is already satisfied with the current workaround

hilary-luo commented 1 year ago

@SteveMacenski This fix worked for me, can we have this merged in? Thanks again

SteveMacenski commented 1 year ago

Done