replace "rclcpp::ok()" by atomic-flag to avoid UAF bug - Githubissues

SteveMacenski / slam_toolbox

Slam Toolbox for lifelong mapping and localization in potentially massive maps with ROS

GNU Lesser General Public License v2.1

1.67k stars 525 forks source link

replace "rclcpp::ok()" by atomic-flag to avoid UAF bug #693

Closed GoesM closed 4 months ago

GoesM commented 6 months ago

Basic Info

Info	Please fill out this column
Ticket(s) this addresses	#691
Primary OS tested on	Ubuntu22.04
Robotic platform tested on	gazebo simulation of Tally

Description of contribution in a few bullet points

add an atomic-flag for threads

Description of documentation updates required from your changes

avoid UAF bug caused by rclcpp::ok() 's wrong work

Future work that may be required in bullet points