search

SteveMacenski / spatio_temporal_voxel_layer

A new voxel layer leveraging modern 3D graphics tools to modernize navigation environmental representations
http://wiki.ros.org/spatio_temporal_voxel_layer
GNU Lesser General Public License v2.1
623 stars 184 forks source link

Add voxel_min_points param for voxel filter (ROS2) #161

Closed akiroz closed 4 years ago

akiroz commented 4 years ago

See #160

nickvaras commented 3 years ago

There's an issue with minimum points per voxel in PCL, so just wanted to confirm what I'd expect, which is that the feature added in this PR doesn't really have any effect when applied?? Unless it's been fixed in newer versions of PCL...

SteveMacenski commented 3 years ago

I'm not sure - I haven't tested this personally, @akiroz I would have thought did since they proposed it

akiroz commented 3 years ago

We actually ended up not using this param in the end but I believe it's been fixed in PCL upstream and planned for the coming 1.12 release.

SteveMacenski commented 3 years ago

This appears to have potentially broken things per https://github.com/SteveMacenski/spatio_temporal_voxel_layer/issues/187 and https://github.com/SteveMacenski/spatio_temporal_voxel_layer/issues/199