search

SteveMacenski / spatio_temporal_voxel_layer

A new voxel layer leveraging modern 3D graphics tools to modernize navigation environmental representations
http://wiki.ros.org/spatio_temporal_voxel_layer
GNU Lesser General Public License v2.1
620 stars 184 forks source link

Replace ROS WallTime with normal ROS Time #205

Closed Flova closed 2 years ago

Flova commented 3 years ago

This fixes issues when the code runs in a slow simulation. Currently, obstacles are removed according to the wall clock which leads to a shorter lifespan in the simulation time.

SteveMacenski commented 3 years ago

Unfortunately, that would break existing behavior for users, so this cannot be merged into already released distributions. I think its a fine thing to do, but it cannot be merged back into already released and maintained distributions for fear that it would severely impact users in the field.

timonegk commented 3 years ago

Maybe it could be configurable? So that the default is walltime but it would be possible to set a parameter to use ros time.

SteveMacenski commented 2 years ago

After further review, I think this is a good idea - merging. Sorry for the delay