SteveMacenski / spatio_temporal_voxel_layer

A new voxel layer leveraging modern 3D graphics tools to modernize navigation environmental representations
http://wiki.ros.org/spatio_temporal_voxel_layer
GNU Lesser General Public License v2.1
620 stars 184 forks source link

Humble build #233

Closed doisyg closed 2 years ago

doisyg commented 2 years ago

Changes for Humble compilation. Current limitation: Ubuntu provided OpenVdb 8.1 issues, see: https://github.com/SteveMacenski/spatio_temporal_voxel_layer/issues/232

Works by uninstalling libopenvdb-dev and building/installing OpenVDB v8.2 (also tried successfully v9.0) from source with these instructions https://github.com/AcademySoftwareFoundation/openvdb#building-openvdb

Draft because not tested for now (just compilation)

SteveMacenski commented 2 years ago

Beyond comments above, just linting spaces between varables / definitions and & and removing a commented out line in the header.

Note that you should try on Cyclone DDS, for Fast-DDS right now callback groups are broke so data won't flow.

I don't think the pub options are required, but I suppose it doesn't hurt.

doisyg commented 2 years ago

Note that you should try on Cyclone DDS, for Fast-DDS right now callback groups are broke so data won't flow.

Of gosh I know, don't get me started on Fast-DDS.

In other news, the launchpad ticket about OpenVDB status changed form New to Confirmed: https://bugs.launchpad.net/ubuntu/+source/openvdb/+bug/1970108

SteveMacenski commented 2 years ago

Ok, I won't :-)

I think this PR is waiting on you for the next step to test / change? Just making sure I'm not the blocking force. No rush.

doisyg commented 2 years ago

This was waiting for me to do some basic sanity checks on a real robot. Done now.

SteveMacenski commented 2 years ago

I'm happy with this if you've tested. @gezp @doisyg any reason not to merge?

doisyg commented 2 years ago

All good on my side given the basic testing I did.

gezp commented 2 years ago

LGTM