Closed doisyg closed 2 years ago
Beyond comments above, just linting spaces between varables / definitions and &
and removing a commented out line in the header.
Note that you should try on Cyclone DDS, for Fast-DDS right now callback groups are broke so data won't flow.
I don't think the pub options are required, but I suppose it doesn't hurt.
Note that you should try on Cyclone DDS, for Fast-DDS right now callback groups are broke so data won't flow.
Of gosh I know, don't get me started on Fast-DDS.
In other news, the launchpad ticket about OpenVDB status changed form New
to Confirmed
: https://bugs.launchpad.net/ubuntu/+source/openvdb/+bug/1970108
Ok, I won't :-)
I think this PR is waiting on you for the next step to test / change? Just making sure I'm not the blocking force. No rush.
This was waiting for me to do some basic sanity checks on a real robot. Done now.
I'm happy with this if you've tested. @gezp @doisyg any reason not to merge?
All good on my side given the basic testing I did.
LGTM
Changes for Humble compilation. Current limitation: Ubuntu provided
OpenVdb 8.1
issues, see: https://github.com/SteveMacenski/spatio_temporal_voxel_layer/issues/232Works by uninstalling
libopenvdb-dev
and building/installing OpenVDB v8.2 (also tried successfully v9.0) from source with these instructions https://github.com/AcademySoftwareFoundation/openvdb#building-openvdbDraft because not tested for now (just compilation)