search

SteveMacenski / spatio_temporal_voxel_layer

A new voxel layer leveraging modern 3D graphics tools to modernize navigation environmental representations
http://wiki.ros.org/spatio_temporal_voxel_layer
GNU Lesser General Public License v2.1
616 stars 183 forks source link

Does the "enabled" parameter work dynamically? #258

Closed dujeong closed 1 year ago

dujeong commented 1 year ago

I wonder if the parameter enabled is a dynamically operated parameter. If I change it using rqt after loading, it doesn't work. (It keeps the initial value)

There seems to be no dynamic change in the "enabled" parameter from the source, is that right?

I also looked up the "enabled" related content in the previous issue list, and it seems to have been related to the problem of unregistering and registering the subscriber.

If the issue has already been answered, can you tell me the link? I would appreciate it if you could let me know if there is anything I am mistaken about the "enabled" parameter.

Below is the yaml file that I set the "enabled" parameter.

      stvl_layer:
        plugin: "spatio_temporal_voxel_layer/SpatioTemporalVoxelLayer"
        enabled: false

And I used stvl by source build. (branch: ros2)

SteveMacenski commented 1 year ago

https://github.com/SteveMacenski/spatio_temporal_voxel_layer/blob/ros2/src/spatio_temporal_voxel_layer.cpp#L835

No, it is not a dynamic parameter, but it could be made one if you opened a PR :smile:

dujeong commented 1 year ago

@SteveMacenski I made PR! Please review the source code. :) https://github.com/SteveMacenski/spatio_temporal_voxel_layer/pull/259

SteveMacenski commented 1 year ago

I'll continue convo in the PR