search

SteveMacenski / spatio_temporal_voxel_layer

A new voxel layer leveraging modern 3D graphics tools to modernize navigation environmental representations
http://wiki.ros.org/spatio_temporal_voxel_layer
GNU Lesser General Public License v2.1
616 stars 183 forks source link

Possible bug in operator() for marking voxels? #292

Closed xaru8145 closed 3 months ago

xaru8145 commented 3 months ago

Hi,

I noticed L295 of spatio_temporal_voxel_grid cpp file uses the value of iter_y to determine the value of z double z = *iter_y < 0 ? *iter_z - _voxel_size : *iter_z; Is this intended or shoud it be this way? double z = *iter_z < 0 ? *iter_z - _voxel_size : *iter_z;

Thanks for your time!

SteveMacenski commented 3 months ago

I'm pretty sure that's a typo. @KavenYau this is from your PR a little over a year ago. Do you agree this is just a typo that we should fix?

KavenYau commented 3 months ago

I'm pretty sure that's a typo. @KavenYau this is from your PR a little over a year ago. Do you agree this is just a typo that we should fix?

Yes, it's definitely a typo. :frowning:

SteveMacenski commented 3 months ago

@xaru8145 can you submit a PR? :smile:

xaru8145 commented 3 months ago

Done @SteveMacenski ! PR #293