search

SteveMacenski / spatio_temporal_voxel_layer

A new voxel layer leveraging modern 3D graphics tools to modernize navigation environmental representations
http://wiki.ros.org/spatio_temporal_voxel_layer
GNU Lesser General Public License v2.1
644 stars 189 forks source link

Fix build by removing linker flags #295

Closed james-ward closed 4 months ago

james-ward commented 4 months ago

Closes #294

Timple commented 4 months ago

Well, this check should not have false positives. But you are right, there is an issue upstream which causes this: https://github.com/ros2/rosidl_python/issues/213

I would put these lines below the message generation, that also works. With a comment why this is at that location referencing the upstream issue.

But I'm also not against removing it as it's just an extra check preventing runtime linking issues.

SteveMacenski commented 4 months ago

That seems reasonable to me. @james-ward can you move it below the messages?

Rayman commented 4 months ago

@james-ward you can also move the linker flags after the messages are generated. Then we still get warnings from our own code, but not from the messages