search

SteveMacenski / spatio_temporal_voxel_layer

A new voxel layer leveraging modern 3D graphics tools to modernize navigation environmental representations
http://wiki.ros.org/spatio_temporal_voxel_layer
GNU Lesser General Public License v2.1
644 stars 189 forks source link

Possible typo? - Callback group not set for PublisherOptions #297

Closed ivrolan closed 4 months ago

ivrolan commented 4 months ago

In ros2 and humble branch, in spatio_temporal_voxel_layer.cpp, the subscriber and publisher options are set in this way:

auto sub_opt = rclcpp::SubscriptionOptions();
sub_opt.callback_group = callback_group_;

auto pub_opt = rclcpp::PublisherOptions();
sub_opt.callback_group = callback_group_;

Note how the sub_opt.callback_group = callback_group_ is set twice, and the pub_opt is left as the default. Is this intended?

SteveMacenski commented 4 months ago

Looks like a typo to me, this isn't a big deal but certainly would be a good PR to have fixed! Can you submit that @ivrolan?

ivrolan commented 4 months ago

Sure! I'll test it and open the PR

SteveMacenski commented 4 months ago

Merging! Thanks for the report