Closed ivrolan closed 1 month ago
In ros2 and humble branch, in spatio_temporal_voxel_layer.cpp, the subscriber and publisher options are set in this way:
ros2
humble
spatio_temporal_voxel_layer.cpp
auto sub_opt = rclcpp::SubscriptionOptions(); sub_opt.callback_group = callback_group_; auto pub_opt = rclcpp::PublisherOptions(); sub_opt.callback_group = callback_group_;
Note how the sub_opt.callback_group = callback_group_ is set twice, and the pub_opt is left as the default. Is this intended?
sub_opt.callback_group = callback_group_
pub_opt
Looks like a typo to me, this isn't a big deal but certainly would be a good PR to have fixed! Can you submit that @ivrolan?
Sure! I'll test it and open the PR
Merging! Thanks for the report
In
ros2
andhumble
branch, inspatio_temporal_voxel_layer.cpp
, the subscriber and publisher options are set in this way:Note how the
sub_opt.callback_group = callback_group_
is set twice, and thepub_opt
is left as the default. Is this intended?