SteveMacenski / spatio_temporal_voxel_layer

A new voxel layer leveraging modern 3D graphics tools to modernize navigation environmental representations
http://wiki.ros.org/spatio_temporal_voxel_layer
GNU Lesser General Public License v2.1
644 stars 189 forks source link

Fix pub_options callback group not set #298

Closed ivrolan closed 4 months ago

ivrolan commented 4 months ago

This PR fixes #297 and sets the callback_group of the publisher options for the voxel_grid publisher. Before the callback_group for the subscriber options was set twice.

Tested on humble with no perceptible changes, everything seems working fine. I don't know exactly the consequences of not setting the callback_group (e.g. get_subscription_count() was also working even with the default options without setting it), but it makes more sense to fix this typo now and prevent future problems.