search

SteveMcGrath / DoFler

Dashboard of Fail. A application to carve out images/accounts/vulns on conference networks and display them for general entertainment.
http://dofler.net
GNU General Public License v2.0
124 stars 18 forks source link

Cross-platform / virtualenv support #4

Closed blha303 closed 8 years ago

blha303 commented 10 years ago

I'm willing to bet DoFler doesn't work on Windows at all, but at least it doesn't error when it's being installed now. Added bonus of virtualenv support.

SteveMcGrath commented 10 years ago

With the use of pyexpect, which is POSIX-only, there isnt really much of a need for nt unless the base parser is completely rewritten to support multiple OSs. That being said, didn't think about virtualenv.

blha303 commented 10 years ago

Yeah, I did the Windows thing without even realising that dofler wouldn't even work on Windows. Then I tested on Linux and realised i could fix virtualenv while I was there. Wow this comment added nothing at all to the conversation.

SteveMcGrath commented 10 years ago

lol I'll tell ya what, If you want to hunt down the paths in the ui.py file and update those as well (should be the static path and the overload for the templates) I'll merge in the whole lot. No point in putting something in that in this state would actually break in virtualenv :-p

blha303 commented 10 years ago

I reckon that's all of it.

SteveMcGrath commented 10 years ago

I totally forgot about the report.py haxory I did to embed everything in, lol. ok, so I dont mean to be picky (actually I do, I'm just lazy and traveling and its easier if you do it), wny not centralize DATA_PREFIX to the config.py module and then just import it in like so:

from dofler.config import DATA_PREFIX

It's cleaner and it's a central point incase it ever needs to be adjusted.

blha303 commented 10 years ago

That's a great idea, and I would have done that to start with, but y'know. I removed it from everywhere except setup.py, I was hopeful that I could import it from dofler.config, but init.py tries to initialize the whole thing, so that's out.

SteveMcGrath commented 10 years ago

Yeah, I have been throwing around the idea of a complete rewrite and restructure for a bit now. I've learned a few new tricks recently, and I'd love to learn how to code to tornado directly, and this seems to be the perfect place to cut my teeth on it.

SteveMcGrath commented 8 years ago

@blha303 you may want to take a look at this rewrite. It's entirely Javascript based now. It should also be a bit more portable as I'm not relying on anything anymore thats POSIX-specific.

blha303 commented 8 years ago

I don't remember this at all, thanks for the update though :D