search

SteveOv / ebop_maven

EBOP Model Automatic input Value Estimation Neural network
GNU General Public License v3.0
1 stars 0 forks source link

Testing failed; LD params out of range on retry of V362 Pav #86

Closed SteveOv closed 3 days ago

SteveOv commented 3 days ago

Copying over LD coefficients output from first fit to be the inputs of the second caused JKTEBOP fit to fail, resulting in an uncaught exception. This was never an issue before, as the LD coefficients were set by either looking up quad/pow2 values from published tables or manually copied over from published characterisations.

The output from JKTEBOP states that some of the coefficients copied over were outside the range (-1, 2).

Need to extend the validation and coercion in the jktebop.write_in_file() function to handle limb darkening coefficients.

Related to #85

SteveOv commented 3 days ago

This is getting unwieldy; improve this logic.