SteveParson / xubuntu-18.04-dev-box

Provision a fresh install of Xubuntu for a developer
MIT License
9 stars 3 forks source link

BUG: Ansible complains about using sed manually in the role definition. #1

Closed SteveParson closed 4 years ago

SteveParson commented 5 years ago

Describe the bug Ansible complains about using sed manually in the role definition.

To Reproduce Steps to reproduce the behavior: Create a new VM and watch the output from Ansible.

Expected behavior I would expect Ansible to not complain about this.

Screenshots image

Desktop (please complete the following information):

Additional context Need to port

- name: Fix xrdp
  shell: "sed -i 's/new_cursors=true/new_cursors=false/g' /etc/xrdp/xrdp.ini"
  become: yes

to use lineinfile

anihm136 commented 4 years ago

I'd like to work on this, if it's still open

SteveParson commented 4 years ago

I'd be happy to accept your pull request!

anihm136 commented 4 years ago

I've created a PR with a new branch to fix this. Check it out and let me know if it works as expected