search

SteveSanderson / knockout-es5

Knockout.js meets ECMAScript 5 properties
157 stars 39 forks source link

Knockout es5 is AMD aware. #10

Closed camswords closed 9 years ago

camswords commented 11 years ago

In the context of AMD, knockout defines itself as a module and does not attach 'ko' to the global object. This causes es5 to fail.

This change defines an AMD module for es5. Knockout is declared as a dependency to ensure that it loaded first.

hipertracker commented 10 years ago

Any reason why is it still not merged to main repo?

deanrad commented 10 years ago

I haven't run this yet, but its intent is spot-on. +1

nathanboktae commented 10 years ago

+1 just ran into this issue myself

michaeldewayneharris commented 9 years ago

I just ran into this issue as well. the fix worked for me. It does require that knockout be named knockout via the paths: {} but otherwise it worked great. I would actually expect it to be "ko" instead of knockout.

SteveSanderson commented 9 years ago

Thanks - AMD support is now in thanks to @brigand