search

SteveSanderson / knockout-es5

Knockout.js meets ECMAScript 5 properties
158 stars 39 forks source link

ko-es5 is not r.js-friendly #28

Closed jods4 closed 9 years ago

jods4 commented 9 years ago

ko-es5 now supports AMD loaders and I'm using it successfully with require.js.

But I can't optimize my application by packaging all modules in a few files with the require.js optimizer (r.js). The issue seems to be that r.js doesn't parse global.define().

I patched lines 335-336 by replacing the 3 global.define with define and now everything works well.

archangel-irk commented 9 years ago

Please create PR and I will be able to take it.

In general, I want to use browserify when building, to avoid some problems.

archangel-irk commented 9 years ago

Practice has shown that the use browserify to be excessive.