search

SteveSanderson / knockout-es5

Knockout.js meets ECMAScript 5 properties
158 stars 39 forks source link

fixed null contains nested object error. #35

Closed alu closed 9 years ago

alu commented 9 years ago

Fixed null contains nested object error. I meet error code below.

ko.track({ key: null }, { deep, true });

output

TypeError: limb is null
trackDeep/<()knockout-es5.js (94 行目)
trackDeep()knockout-es5.js (90 行目)
track()knockout-es5.js (63 行目)

(('Object' === getFunctionName(limb.constructor)
archangel-irk commented 9 years ago

Thank you for your bug report, the changes will be merged manually.

archangel-irk commented 9 years ago

was fixed in https://github.com/SteveSanderson/knockout-es5/pull/38

test added https://github.com/SteveSanderson/knockout-es5/commit/916f25152e9021f667c48cddcb94165f79bbcb97